Ensure license headers match the Cargo manifest licenses #5776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alvicsam
approved these changes
Sep 19, 2024
mordamax
approved these changes
Sep 19, 2024
EgorPopelyaev
approved these changes
Sep 24, 2024
mutantcornholio
force-pushed
the
rzadp/ensure-license-manifest
branch
from
d0e2eea to
4f12daa
Compare
mutantcornholio
force-pushed
the
rzadp/ensure-license-manifest
branch
from
4f12daa to
897830b
Compare
3 tasks
kianenigma
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cargo.tomllicense-scanner#44What's inside
First, we change the file traversal mechanism from shell globbing to walking through files which happens inside the
license-scanner- so it has knowledge about directory structure and can correlate files with corresponding Cargo manifest.Next, added
MIT-0andUnlicenseto the allowed list of licenses.Unlicenseappears only once across {Substrate,Cumulus,Polkadot} - inpenpal-runtime.Finally, updated headers in files that do not match the corresponding manifest license.